Appimage v2 #1101

mssalvatore · 2021-04-14T18:46:42Z

What does this PR do?

This PR contains version 2 of the build scripts and artifacts for an AppImage package.

Fixes #1090

Add any further explanations here.

PR Checklist

Have you added an explanation of what your changes do and why you'd like to include them?
Is the TravisCI build passing?
Was the CHANGELOG.md updated to reflect the changes?
Was the documentation framework updated to reflect the changes?

Testing Checklist

Added relevant unit tests?
Have you successfully tested your changes locally? Elaborate:

Tested by building an AppImage and running it on Ubuntu Bionic and Focal, CentOS 8, and Kali 2021.1
If applicable, add screenshots or log transcripts of the feature working

deployment_scripts/appimage/AppRun

deployment_scripts/appimage/build_appimage.sh

appimage/AppRun

appimage/build_appimage.sh

appimage/run_appimage.sh

codecov · 2021-04-15T11:47:11Z

Codecov Report

Merging #1101 (f3439bb) into develop (2d7919c) will increase coverage by 0.74%.
The diff coverage is 20.22%.

@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
+ Coverage    28.27%   29.01%   +0.74%     
===========================================
  Files          398      409      +11     
  Lines        12804    12911     +107     
===========================================
+ Hits          3620     3746     +126     
+ Misses        9184     9165      -19

Impacted Files	Coverage Δ
monkey/common/cloud/instance.py	`66.66% <ø> (ø)`
monkey/common/cmd/aws/aws_cmd_result.py	`0.00% <0.00%> (ø)`
monkey/common/cmd/aws/aws_cmd_runner.py	`0.00% <0.00%> (ø)`
monkey/common/cmd/cmd.py	`0.00% <0.00%> (ø)`
monkey/common/cmd/cmd_result.py	`0.00% <0.00%> (ø)`
monkey/common/cmd/cmd_runner.py	`0.00% <0.00%> (ø)`
monkey/common/cmd/cmd_status.py	`0.00% <0.00%> (ø)`
monkey/common/common_consts/network_consts.py	`0.00% <0.00%> (ø)`
monkey/common/network/segmentation_utils.py	`100.00% <ø> (ø)`
monkey/common/utils/mongo_utils.py	`0.00% <0.00%> (ø)`
... and 930 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a4062...f3439bb. Read the comment docs.

monkey/infection_monkey/monkey.py

VakarisZ

Approved, but have some questions

This file was used by appimage-builder, which we are no longer using.

Since AppImages are read-only filesystems, the agent cannot create any files in `./`. Therefore, setting cwd in the `subprocess.Popen()` call will change CWD to a writable directory if `data_dir` is set.

mssalvatore added 8 commits April 12, 2021 08:03

build: Use official deployment_scripts/config in build_appimage.sh

21a2083

build: Build AppImage with appimagetool instead of appimage-builder

638004c

build: remove unnecessary python packages from appimage build

9f74127

build: Remove unnecessary mkdir in build_appimage.sh

38a9ced

build: Organize appdir-specific tasks in setup_appdir()

312c98c

build: Move some constants to top of build_appimage.sh

9d8fc48

build: Address shellcheck warnings in run_appimage.sh

a58f310

cc: Upload custom PBAs to data_dir instead of MONKEY_ISLAND_ABS_PATH

3b4bd7b

mssalvatore requested a review from VakarisZ April 14, 2021 18:46