Environment config section #1161
Conversation
Put the environment config inside its own "environment" object in the server_config.json to provide a logical separation between the environment config, logger config, data directory, etc.
Codecov Report
@@ Coverage Diff @@
## develop #1161 +/- ##
===========================================
+ Coverage 28.78% 28.92% +0.13%
===========================================
Files 414 415 +1
Lines 12758 12904 +146
===========================================
+ Hits 3673 3732 +59
- Misses 9085 9172 +87
Continue to review full report at Codecov.
|
| @@ -1,5 +1,8 @@ | |||
| { | |||
| "server_config": "password", | |||
| "deployment": "develop", | |||
There was a problem hiding this comment.
| "deployment": "develop", | |
| "data_dir": "$HOME/.monkey_island", |
There was a problem hiding this comment.
Since the island will supply a default data_dir, I'd prefer to leave this out. Otherwise we need a .develop.linux and a .develop.windows file to cover multiple development platforms.
There was a problem hiding this comment.
Right. This should be removed then, there's already a "deployment" in "environment".
What does this PR do?
Issue #1146
Creates an "environment" section in the config to separate the environment config from the non-environment config options.
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
If applicable, add screenshots or log transcripts of the feature working