Skip to content

Create a temporary directory for zerologon artifacts #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2021
Merged

Create a temporary directory for zerologon artifacts #1143

merged 2 commits into from
May 4, 2021

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented May 4, 2021 •
edited
Loading

What does this PR do?

Zerologon exploiter writes runtime artifacts to a secure temporary directory instead of $HOME

This PR is in support of #1133.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the zerologon blackbox test.

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore
agent: Create a temporary directory for zerologon artifacts
85b079c 
Not all users are guaranteed to have a $HOME. Use a temporary directory
instead.
@mssalvatore mssalvatore requested a review from shreyamalviya May 4, 2021 12:35
@codecov
Copy link

codecov bot commented May 4, 2021 •
edited
Loading

Codecov Report

Merging #1143 (93bb14f) into develop (7f06ec4) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1143      +/-   ##
===========================================
+ Coverage    28.71%   28.73%   +0.01%     
===========================================
  Files          410      410              
  Lines        12877    12883       +6     
===========================================
+ Hits          3698     3702       +4     
- Misses        9179     9181       +2
Impacted Files Coverage Δ
...ion_monkey/exploit/zerologon_utils/remote_shell.py 17.70% <33.33%> (-0.19%) ⬇️
...nfection_monkey/exploit/zerologon_utils/wmiexec.py 33.33% <50.00%> (-0.82%) ⬇️
monkey/infection_monkey/exploit/zerologon.py 30.82% <80.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f06ec4...93bb14f. Read the comment docs.

@mssalvatore mssalvatore merged commit 341af22 into develop May 4, 2021
@mssalvatore mssalvatore deleted the zerologon-tmp-dir branch May 4, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mssalvatore @shreyamalviya