-
Notifications
You must be signed in to change notification settings - Fork 807
Closed
Description
Refactor
Component(s) to be refactored
- Common.credentials.Credentials
Explanation
The Credentials
object represents a many-to-many relationship between identities and secrets. This adds complexity in storage, usage, and serialization. The benefits of this additional complexity are that we can maintain relationships between identities and the amount of data passed between the island and agent is reduced. We don't know that relationships between identities will ever be valuable. The increase in data transfer will likely be minimal and could be mitigated by using compression if it ever became a real issue.
Refactor the Credentials
object to contain one single identity and one single secret.
- Modify the object to only have one identity and one secret. Refactor all of the code that uses it. (0d) @mssalvatore
- Modify
ControlChannel.get_propagation_credentials
to use the simplified Credenetials object. (0d) @mssalvatore- Fix aggregating_credentials_store