-
Notifications
You must be signed in to change notification settings - Fork 807
Closed
Labels
Beginner friendlyNew to the project? This issue is good for you!New to the project? This issue is good for you!Code QualityDeficiencies in code qualityDeficiencies in code qualityComplexity: LowHelp wantedImpact: MediumPerformanceRefactor
Description
When Monkey Island starts, it checks to see if it's running on an AWS instance. When it performs this check, it makes 2 calls, each with a 2-second timeout. In the case where the Island is not running on an AWS instance, this adds approximately 2-4 seconds to the startup of the Island. For users, this is a mild inconvenience. For developers, it's a full-blown annoyance.
Find a way to eliminate this delay. Possible solutions might be:
- Lazy-load the AwsInstance object in RemoteRunAwsService, so that it's not actually created until it's need.
- Initialize the RemoteRunAwsService on a separate thread so that it does not delay the rest of the startup process.
Note: This doesn't seem to be an issue while running from source on Windows (with pycharm) but does manifest when run from the MSI. It also manifests while running from source on Linux.
Tasks
- Fix it! (0.5d) - @VakarisZ
Metadata
Metadata
Assignees
Labels
Beginner friendlyNew to the project? This issue is good for you!New to the project? This issue is good for you!Code QualityDeficiencies in code qualityDeficiencies in code qualityComplexity: LowHelp wantedImpact: MediumPerformanceRefactor