Skip to content

"deployment" field should not be stored in server_config.json #1205

@mssalvatore

Description

@mssalvatore

The deployment field is not a runtime configuration option. It is a way for Guardicore to track which versions of Infection Monkey are being used. (See https://www.guardicore.com/infectionmonkey/docs/faq/#exactly-what-internet-queries-does-the-infection-monkey-perform for details about what information is being collected.) As such, it should not be stored in the same file with user-configurable options, but should be stored in a read-only location.

  • Delete the deployment option from server_config.json. (0d) - @shreyamalviya
  • Extract deployment name into a separate file in monkey_island/cc/deployment.json and make it develop by default. Change the monkey code to use this file as source of truth. (0d) - @shreyamalviya, @ilija-lazoroski
  • Add UTs for reading the monkey_island/cc/deployment.json and fix the tests in monkey/tests/unit_tests/monkey_island/cc/environment/test_environment_config.py. (0d) @ilija-lazoroski, @shreyamalviya
  • Modify build scripts to write out the deployment name into monkey_island/cc/deployment.json. (0d) @ilija-lazoroski
  • Build all of the deployments and make sure the deployment is correct. (0d)
    • Run all deployments
    • Verify that correct IP address and deployment name appears in the lamda (check the confluence)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions