Skip to content

New installations don't clean the database #1114

@VakarisZ

Description

@VakarisZ

Describe the bug

New installations doesn't clean the database, so when users update, the monkey crashes, because of the old database.

To Reproduce

Steps to reproduce the behavior:

  1. Install 1.7
  2. Run monkey
  3. Update to 1.10
  4. Monkey tries to use 1.7 database and crashes

Expected behavior

On installation, database directory should be found and cleaned. Update: the whole data dir should probably be cleaned.

Screenshots

image

Machine version (please complete the following information):

  • OS: Windows or Linux (unknown, likely both)

Tasks

Tasks:

  • Alter MSI installers to remove the default data_dir on uninstall: - @VakarisZ
  • Add the below logic to ensure a smooth upgrade process for AppImage or MSI with custom data_dir - @VakarisZ

Pseudocode

def island_start():
    if data_dir exists:
        if data_dir/version exists and not my_version == data_dir/version:
            rename data_dir
        else if not data_dir/version exists:
            rename data_dir

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugAn error, flaw, misbehavior or failure in the Monkey or Monkey Island.Complexity: HighExpertIssue requires specific knowledge or access to internal resources and is not suitable for beginnersImpact: HighRelease

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions