Skip to content

Run code validation checks with pre-commit #974

@VakarisZ

Description

@VakarisZ

Is your feature request related to a problem? Please describe.
We should run the same or more code validation tools that our Travis runs using https://pre-commit.com/.

Describe the solution you'd like
Pre-commit tool should run a local validation script and verify that new commit doesn't break UT's, doesn't introduce new flake8 warnings etc.

Describe alternatives you've considered
Using git-hooks

  • Add config for pre-commit. (0d) - @mssalvatore
  • Add pre-commit hook for black. Ensure travis CI uses the same version. (0d) - @mssalvatore
  • Add pre-commit hook for flake8. Ensure travis CI uses the same version. (0d) - @mssalvatore
  • Add pre-commit hook for isort. Ensure travis CI uses the same version. (0d) - @mssalvatore
  • Alter linux deployment script to install and run pre-commit. (0d) - @mssalvatore
  • Alter windows deployment script to install and run pre-commit (0.25d) - @VakarisZ
  • Update dev documentation to include instructions about pre-commit and a warning that CI will reject non-compliant code. (0d) - @mssalvatore

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions