Skip to content

Conversation

kelvin-chappell
Copy link
Member

@kelvin-chappell kelvin-chappell commented Jan 5, 2024

What is the value of this and can you measure success?

Should eliminate any vulnerable transitive dependencies that the old Identity libraries may have been bringing in. Also will make it easier to keep Identity libraries up to date in future as we don't expect to make so many breaking changes in future.

What does this change?

Bumps Identity libraries from v3.255 to v4.17.

There will need to be some future work in the next few weeks to support Okta authorisation of endpoints or removing the authorised endpoints altogether if they prove to be redundant.

Checklist

@kelvin-chappell kelvin-chappell requested a review from a team as a code owner January 5, 2024 16:21
@kelvin-chappell kelvin-chappell marked this pull request as draft January 5, 2024 16:21
@kelvin-chappell kelvin-chappell force-pushed the kc/identity-bump branch 2 times, most recently from 832b68b to 3edf531 Compare January 10, 2024 09:36
@kelvin-chappell kelvin-chappell changed the title WIP Bump Identity libraries Jan 10, 2024
@kelvin-chappell kelvin-chappell requested a review from a team January 11, 2024 13:30
@kelvin-chappell kelvin-chappell marked this pull request as ready for review January 11, 2024 13:31
Copy link
Member

@coldlink coldlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but we should figure out what's actually using this library is frontend in order to ideally remove it.

@prout-bot
Copy link

Seen on ADMIN-PROD (merged by @kelvin-chappell 12 minutes and 19 seconds ago)

@prout-bot
Copy link

Seen on FRONTS-PROD (merged by @kelvin-chappell 12 minutes and 39 seconds ago)

@mxdvl mxdvl mentioned this pull request Jan 23, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants