Skip to content

Fix Spacefinder timeout hit with interactives #11077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2024
Merged

Fix Spacefinder timeout hit with interactives #11077

merged 2 commits into from
Apr 4, 2024

Conversation

deedeeh
Copy link
Contributor

@deedeeh deedeeh commented Apr 4, 2024 •
edited
Loading

What does this change?

This PR fixes the Commercial logger message 'Spacefinder timeout hit' by replacing visible with idle after confirming with @mxdvl from WebEx that it is safe to do so.

We have a 5000 timeout for Spacefinder and as you can see from the 'Before' screenshot all different ad sizes that will be inserted by Spacefinder exceeds that time.

The change has been tested locally and in CODE with these articles https://www.theguardian.com/artanddesign/2024/mar/19/damien-hirst-formaldehyde-animal-works-dated-to-1990s-were-made-in-2017 (Get in touch) and https://www.theguardian.com/society/2024/mar/20/young-people-becoming-less-happy-than-older-generations-research-shows (chart).

Why?

Spacefinder will be able to make decisions about where to place ads without the timeout.

Screenshots

Before After
image image

@deedeeh deedeeh requested a review from a team as a code owner April 4, 2024 12:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Size Change: 0 B

Total Size: 761 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1225.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/1299.client.web.********************.js 926 B 0 B
dotcom-rendering/dist/134.client.web.********************.js 528 B 0 B
dotcom-rendering/dist/1420.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/15.client.web.********************.js 3.68 kB 0 B
dotcom-rendering/dist/1647.client.web.********************.js 2.93 kB 0 B
dotcom-rendering/dist/2122.client.web.********************.js 3.4 kB 0 B
dotcom-rendering/dist/2253.client.web.********************.js 10.3 kB 0 B
dotcom-rendering/dist/23.client.web.********************.js 2.54 kB 0 B
dotcom-rendering/dist/2342.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/2471.client.web.********************.js 715 B 0 B
dotcom-rendering/dist/2778.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/2797.client.web.********************.js 4.81 kB 0 B
dotcom-rendering/dist/3000.client.web.********************.js 887 B 0 B
dotcom-rendering/dist/3035.client.web.********************.js 2.88 kB 0 B
dotcom-rendering/dist/309.client.web.********************.js 3.86 kB 0 B
dotcom-rendering/dist/3114.client.web.********************.js 651 B 0 B
dotcom-rendering/dist/3118.client.web.********************.js 496 B 0 B
dotcom-rendering/dist/3255.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3303.client.web.********************.js 6.01 kB 0 B
dotcom-rendering/dist/3325.client.web.********************.js 3.14 kB 0 B
dotcom-rendering/dist/3336.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/3364.client.web.********************.js 4.77 kB 0 B
dotcom-rendering/dist/3368.client.web.********************.js 3.75 kB 0 B
dotcom-rendering/dist/3494.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/3503.client.web.********************.js 438 B 0 B
dotcom-rendering/dist/3514.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/3642.client.web.********************.js 787 B 0 B
dotcom-rendering/dist/3922.client.web.********************.js 724 B 0 B
dotcom-rendering/dist/3932.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/4164.client.web.********************.js 3.56 kB 0 B
dotcom-rendering/dist/424.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/4248.client.web.********************.js 3.81 kB 0 B
dotcom-rendering/dist/4367.client.web.********************.js 3.42 kB 0 B
dotcom-rendering/dist/4401.client.web.********************.js 8.68 kB 0 B
dotcom-rendering/dist/4442.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/4673.client.web.********************.js 723 B 0 B
dotcom-rendering/dist/4811.client.web.********************.js 994 B 0 B
dotcom-rendering/dist/5044.client.web.********************.js 802 B 0 B
dotcom-rendering/dist/5084.client.web.********************.js 751 B 0 B
dotcom-rendering/dist/516.client.web.********************.js 5.86 kB 0 B
dotcom-rendering/dist/5291.client.web.********************.js 2.65 kB 0 B
dotcom-rendering/dist/5308.client.web.********************.js 2.7 kB 0 B
dotcom-rendering/dist/5346.client.web.********************.js 23.2 kB 0 B
dotcom-rendering/dist/5417.client.web.********************.js 3.49 kB 0 B
dotcom-rendering/dist/565.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/5786.client.web.********************.js 1.85 kB 0 B
dotcom-rendering/dist/5817.client.web.********************.js 915 B 0 B
dotcom-rendering/dist/5874.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/6049.client.web.********************.js 3 kB 0 B
dotcom-rendering/dist/6093.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/6167.client.web.********************.js 640 B 0 B
dotcom-rendering/dist/6405.client.web.********************.js 3.14 kB 0 B
dotcom-rendering/dist/6640.client.web.********************.js 906 B 0 B
dotcom-rendering/dist/676.client.web.********************.js 3.87 kB 0 B
dotcom-rendering/dist/6792.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/6871.client.web.********************.js 4.83 kB 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7196.client.web.********************.js 889 B 0 B
dotcom-rendering/dist/72.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/7310.client.web.********************.js 2.95 kB 0 B
dotcom-rendering/dist/7387.client.web.********************.js 955 B 0 B
dotcom-rendering/dist/7522.client.web.********************.js 4.19 kB 0 B
dotcom-rendering/dist/7702.client.web.********************.js 527 B 0 B
dotcom-rendering/dist/7723.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/7799.client.web.********************.js 5.76 kB 0 B
dotcom-rendering/dist/7951.client.web.********************.js 2.67 kB 0 B
dotcom-rendering/dist/8134.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/8135.client.web.********************.js 4.59 kB 0 B
dotcom-rendering/dist/8179.client.web.********************.js 825 B 0 B
dotcom-rendering/dist/8565.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/8606.client.web.********************.js 1.56 kB 0 B
dotcom-rendering/dist/8678.client.web.********************.js 5.9 kB 0 B
dotcom-rendering/dist/8699.client.web.********************.js 619 B 0 B
dotcom-rendering/dist/877.client.web.********************.js 17.9 kB 0 B
dotcom-rendering/dist/8776.client.web.********************.js 2.98 kB 0 B
dotcom-rendering/dist/8791.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/8824.client.web.********************.js 8.6 kB 0 B
dotcom-rendering/dist/8861.client.web.********************.js 2.81 kB 0 B
dotcom-rendering/dist/889.client.web.********************.js 854 B 0 B
dotcom-rendering/dist/8907.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/8995.client.web.********************.js 3.6 kB 0 B
dotcom-rendering/dist/9060.client.web.********************.js 877 B 0 B
dotcom-rendering/dist/9068.client.web.********************.js 3.46 kB 0 B
dotcom-rendering/dist/9107.client.web.********************.js 41.7 kB 0 B
dotcom-rendering/dist/9157.client.web.********************.js 8.3 kB 0 B
dotcom-rendering/dist/9225.client.web.********************.js 582 B 0 B
dotcom-rendering/dist/9359.client.web.********************.js 3.67 kB 0 B
dotcom-rendering/dist/9396.client.web.********************.js 680 B 0 B
dotcom-rendering/dist/9430.client.web.********************.js 508 B 0 B
dotcom-rendering/dist/9625.client.web.********************.js 12.8 kB 0 B
dotcom-rendering/dist/9707.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/9789.client.web.********************.js 922 B 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.76 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 424 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 4.15 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.46 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.61 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.04 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 2.77 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.91 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.76 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.78 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 4.84 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 5.57 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 5.66 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 541 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.28 kB 0 B
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 2.46 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 4.05 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.67 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.6 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.16 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 3.35 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 612 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 832 B 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 342 B 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.7 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 3.81 kB +1 B (0%)
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.8 kB -1 B (0%)
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 1.66 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.65 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 15 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 9.45 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 782 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 12.3 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 47.6 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.69 kB 0 B
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 856 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.09 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.7 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 3.49 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.59 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 2.21 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 436 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.46 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.85 kB 0 B
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.95 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 6.63 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.69 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.31 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 4.04 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 6.73 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js 4.44 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 4.05 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 543 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 801 B 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 752 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 540 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 470 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.9 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 1.99 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 6.24 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js 4.43 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.14 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 769 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 481 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.52 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 645 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 5.72 kB 0 B
dotcom-rendering/dist/SignInGateCustomizableText.client.web.********************.js 955 B 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 1.19 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 2.69 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.53 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 4.6 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.52 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 3.94 kB 0 B
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 2.24 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 3.78 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.16 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 1.24 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.7 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.69 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 5.46 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 4.11 kB 0 B

compressed-size-action

@deedeeh deedeeh requested a review from a team April 4, 2024 12:12
@deedeeh deedeeh mentioned this pull request Apr 4, 2024
Merged
mxdvl
mxdvl approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

We might want to set the same timeout for the internals of whenIdle. What about 500 in both cases? This can be done as a follow-up to keep changes atomic.

@deedeeh
Copy link
Contributor Author

deedeeh commented Apr 4, 2024

This looks good to me.

We might want to set the same timeout for the internals of whenIdle. What about 500 in both cases? This can be done as a follow-up to keep changes atomic.

Yes we talked about that! Sorry for forgetting to make that change but I agree with you it is better to have it in another PR.

@deedeeh deedeeh added the run_chromatic Runs chromatic when label is applied label Apr 4, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Apr 4, 2024
Jakeii
Jakeii approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice investigation! 🕵️‍♂️

@deedeeh deedeeh merged commit a4b1cac into main Apr 4, 2024
@deedeeh deedeeh deleted the dina/fix-spacefinder-timeout-with-interactives branch April 4, 2024 13:43
@prout-bot
Copy link

Seen on PROD (merged by @deedeeh 20 minutes and 43 seconds ago) Please check your changes!

@deedeeh deedeeh mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakeii Jakeii Jakeii approved these changes

+1 more reviewer

@mxdvl mxdvl mxdvl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Commercial 💰 dotcom-rendering Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deedeeh @prout-bot @mxdvl @Jakeii