-
Notifications
You must be signed in to change notification settings - Fork 249
Closed
Labels
✨ FeatureAdds a new featureAdds a new feature
Description
UPDATE/SUMMARY: TCP functionality shouldn't be in Listen (which aims at portability) - see comments. As a Guard plugin - maybe.
A built in TCP server within Listen makes little sense, because:
- the host/port setup for broadcast/recipient modes is confusing and complex
- the current TCP server mode is unreliable on Windows (see Replace Celluloid::IO with native code (for TCP) #246)
- it adds an otherwise unnecessary dependency on Celluloid::IO
- it makes contribution tougher (
listen
is already too complex as it is) - the message protocol should be versioned anyway
- the user should have more control over the TCP setup and which events to create and send and why (without needing changes in Listen), which files/dirs to ignore, etc.
I'd suggest something like listen_tcp_server
which would simply use Listen
as any other app would.
Any suggestions regarding the name and the implementation would be appreciated. (I can't promise much support aside from moving the existing Celluloid::IO-based TCP server into a separate gem).
Metadata
Metadata
Assignees
Labels
✨ FeatureAdds a new featureAdds a new feature