Fixed some of my own metaprogramming-helper mistakes #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It should really be mat2::cols
- Oops, I mixed up the row_type and col_type typedefs
- Having it as __m128 didn't quite feel consistent with vec4/quat
- They didn't even have implementations
- Add new tests to the matrix types - Add vector tests to use the static values instead of constants - Wrap the quaternion tests in #ifdefs - Add new tests to the simdMat4 and simdVec4 tests
Groovounet
added a commit
that referenced
this pull request
Jul 25, 2015
Fixed some of my own metaprogramming-helper mistakes #368
|
It looks great, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, I accidentally got the
type::rowsandtype::colsconstants backwards. So I reversed them. I also fixed the naming format2::columns(it should've beencols). Lastly, I added some more tests.Sorry about that.