Fixed (u)int64 MSB/LSB handling on BE archs #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for the record - BE == big endian :-) |
Groovounet
added a commit
that referenced
this pull request
Mar 15, 2015
Fixed (u)int64 MSB/LSB handling on BE archs #306
|
Thanks for contributing! |
Groovounet
pushed a commit
that referenced
this pull request
Mar 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
test-core_func_integer fails on BE machines(ppc, s390,...). Specifically imul/umul (u)int tests. This is caused by incorrect handling of MSB/LSB parts of (u)int64 value in corresponding functions. This pull request fixes this issue. I have tested it in Fedora 21/rawhide on ppc64, s390(x), x86(_64), arm7 and aarch64.
Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1185298