Skip to content

Fixed calculation of m02 minor for mat4x4 adjugate #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fixed calculation of m02 minor for mat4x4 adjugate #1035

merged 1 commit into from
Nov 9, 2020

Conversation

ainodalok
Copy link

A fix for a function that calculates adjugate of a 4x4 matrix in glm\gtx\matrix_operations.inl

template<typename T , qualifier Q>
GLM_FUNC_DECL mat< 4, 4, T, Q > adjugate (mat< 4, 4, T, Q > const &m)

Minor m02 was derived from a 3x3 submatrix which element [1][1] was m[2][2] instead of the m[2][1].

@Groovounet
Copy link
Member

I am guessing a unit test would be great...

@Groovounet Groovounet merged commit 596577f into g-truc:master Nov 9, 2020
@Groovounet
Copy link
Member

Thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ainodalok @Groovounet