Added a quaternion-based "Look At" function #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Christophe |
Groovounet
added a commit
that referenced
this pull request
Jul 24, 2017
Groovounet
added a commit
that referenced
this pull request
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in this feature request this function computes a unit quaternion that describes the rotation between screen coordinates and a given camera orientation specified by a view and up directions. The rotation quatLookAt(target - eye, up) is the inverse of the rotational part of lookAt(eye, center, up) and therefore one has to take the conjugate to compute a view matrix.
Instead of implementing it directly by means of quaternions, I chose to compute the according rotation matrix and then convert it into a quaternion since benchmarks indicated that this is faster than using quaternions only. The handedness of the coordinates is taken into account in the same fashion as in the matrix lookAt.
The test checks if a certain camera configuration produces a unit quaternion and if it is equivalent to the corresponding matrix lookAt.