Add constructors to aid in meta-programming #421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also removed all degree symbols from test/gtc/gtc_quaternion.cpp - It made editing it a pain in the ass - Oh, added tests for the new constructors for quat, too
- Tests, too
- Tests, too
- Tests, too
- Tests, too - Also, removed a line from the simdVec4 test (there's no operator+, apparently)
|
I don't think that accumulating option is a solution for GLM as this is growing in too much complexity. If you really need such functionality for metaprogramming purposes, you should be able to write code outside GLM to produce the same behavior. Thanks, |
|
What would you suggest, then? |
? |
|
I'll look to see if doing so will make my code smaller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project of mine, I need to be able to have functions that convert between all the different vector types at will (and matrices, and quaternions). I do not feel like writing 225 different functions (
vec2,vec3, andvec4, times the 5 instantiations I care about) to do this. I managed to make it work with templates, but it's not pretty. If I could just use one constructor interface for each vector type, it would make things much easier on me. So I did.