Skip to content

orientate3 vs. orientate4 #207

@mortennobel

Description

@mortennobel

There seems to be an inconsistency between orientate3 vs. orientate4 (eulers_angles.inl). Note that the parameters of yawPitchRoll is different. I believe the orientate4 is the correct order.

template <typename T, precision P>
GLM_FUNC_QUALIFIER detail::tmat3x3<T, P> orientate3
(
    detail::tvec3<T, P> const & angles
)
{
    return detail::tmat3x3<T, P>(yawPitchRoll(angles.x, angles.y, angles.z));
}

template <typename T, precision P>
GLM_FUNC_QUALIFIER detail::tmat4x4<T, P> orientate4
(
    detail::tvec3<T, P> const & angles
)
{
    return yawPitchRoll(angles.z, angles.x, angles.y);
}

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions