forked from select2/select2
-
Notifications
You must be signed in to change notification settings - Fork 0
merging origin master #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue when any of Select2's special options are called on multiple elements, it would only affect the first option in the group. This was because Select2 was only applying any changes to the first element in the group (as chosen by jQuery) instead of applying changes on each and every element within the list. This has the new side effect of special options like `select2('data')` returning the results for the last element in the list instead of the first element. Because the previous functionality was considered unspecified behaviour, this is not being treated as a breaking change. This closes #3413 This closes #3495
Update component.json
… the dropdown (otherwise the container is undefined)
Add sr-Cyrl language.
Add the decorator parameter to the handlers for the attach and detach of the dropdown
This fixes a previous bug with the backspace handler on the multiple select search box where unselecting a choice through the keyboard would not properly size the search box. As a result, most of the text would be cut off and it was very clear that there was an issue. In addition, a blank space was automatically being added to the end of the search query. This blank space would not be removed at all, so the user had to manually remove it. Additionally, a query would be triggered for the last used search term instead of the new search term that would be loaded in. This caused incorrect results to be displayed most of the time. All of these issues have been fixed by triggering a new search query after an option has been removed through the keyboard. This will resize the search box automatically, which fixes the main issue, and it will trigger a search with the correct query. This closes #3297 This closes #3398
This closes #3222.
In f1e8647 we tried to fix the issue where multiple instances created in a single call would share the same options, and this worked for the most common cases. Unfortunately it did not work for the case where data attributes were also used with an options object, and as a result data attributes would be copied to all instances. Data attributes are supposed to be specific to a single instance. This was fixed by moving the `true` for the deep copy to the start of the `$.extend` call, as this is where jQuery looks for the deep copy flag. This closes #3485
Correct Typo in noResults
These are technically only required when building the final versions, but if someone is pulling from NPM they may want to deal with building it as well. Almond is used for loading in packages and jQuery Mousewheel is used to prevent the results from scrolling the page.
This fixes the implicit requirement of jquery-mousewheel that previously existed. This was not allowed, as pointed out in #3287 (comment) Now the requirement is more explicit, so everything should work as it was before.
This changes the Grunt script to automatically pull the locations of the NPM versions of the Almond loader and jQuery mousewheel plugin. This means we no longer need to include these vendor files in our repository, as the builds will automatically pull from the existing NPM files.
This fixes an infinite loop that used to be caused when both `closeOnSelect` and `selectOnClose` used to be combined, because they both were listening to events triggered by the other one. The problem was that `selectOnClose` was triggering `select` events for data objects which had already been selected. This problem was solved by checking if the data object was already selected before trying to select it again. This closes #3751. This closes #3169.
This fixes an issue with non-static parents (ones that were relatively or absolutely positioned) where the dropdown would be offset by the offset of the parent, so it would almost never line up. This fixes the problem by removing the offset when the parent is not statically positioned, which is what we used to do in older versions of Select2. This closes #3303. This closes #3614. This closes #3672.
This is just a basic test that ensures that the dropdown is appended to the end of the dropdown parent when `dropdownParent` is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.