Skip to content

Conversation

Code0x58
Copy link
Contributor

@Code0x58 Code0x58 commented Aug 1, 2021

What does this pull request do?

this builds on @shogo82148's #376 ("introduce GitHub Actions") for #373 by increasing the range of versions tested and adding a linting stage to reflect what was in TravisCI config.

I've tested this on my own fork and it passes [actions page]

Notes:

  • 1.9+1.10 skipped as they broke on ubuntu+macos with "kqueue.go:18:2: cannot find package "golang.org/x/sys/unix" in any of:" - I assume gomod related and reasonable to skip (Travis CI did run with these back in the day)
  • currently failures in the lint job in golangci-lint are are allowed, to avoid making changes to the code

Copy link
Contributor

@nathany nathany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much for doing this!

@nathany nathany merged commit 5ce1ba4 into fsnotify:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants