Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fsnotify/fsevents
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.1
Choose a base ref
...
head repository: fsnotify/fsevents
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.0
Choose a head ref
  • 14 commits
  • 62 files changed
  • 6 contributors

Commits on Jan 16, 2022

  1. Configuration menu
    Copy the full SHA
    86ddfd0 View commit details
    Browse the repository at this point in the history
  2. Create test Action (#54)

    * Create test Action
    
    Copied from fsnotify and restricted to macOS
    
    * fixes broken test on macOS 11.5.2
    pbnjay authored Jan 16, 2022
    Configuration menu
    Copy the full SHA
    12a6013 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5973c50 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Remove Travis CI and Code Cov (#56)

    * Remove Travis CI and Code Cov
    
    replace with GitHub Actions in #54
    nathany authored Jan 19, 2022
    Configuration menu
    Copy the full SHA
    66dfb65 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. fsevents: improve documentation (#52)

    This PR adds comprehensive doc comments to all exported
    constants, mostly derived from the Apple documentation
    but with changes to make them directly relevant to this package's API.
    
    It also uses C constants directly rather than relying on an implicit
    association between `1<<iota` and the actual enum values.
    
    It also unexports `GetStreamRefPaths`, `GetStreamRefDescription`
    and `GetStreamRefDeviceID`  because none of them are usable
    with this package's API because there is no way to get an
    `FSEventStreamRef` value because it's hidden inside an unexported
    field inside the `EventStream` struct.
    
    Also unexport the `CFRunLoopRef` because it's similarly
    not useful or usable.
    
    Other than the above unexports, the API remains identical.
    
    Unfortunately I am unable to get the tests to pass, which
    makes me think that something is wrong somewhere, but
    that applies to the original code too, not just the code with
    these changes applied.
    rogpeppe authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    0bd000f View commit details
    Browse the repository at this point in the history
  2. Check for errors during FSEventStreamStart (#57)

    * Return an error if FSEventStreamStart fails
    
    * Validate the 4096 path limit and error detection
    
    * Add notes for #46 and #48 limitations of macOS
    
    Co-authored-by: Martin Tournoij <martin@arp242.net>
    pbnjay and arp242 authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    3899270 View commit details
    Browse the repository at this point in the history
  3. Remove support for old Go versions

    Fixes #51
    arp242 committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ba99ec5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    23269be View commit details
    Browse the repository at this point in the history
  5. Update link

    arp242 committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    69514f1 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Fix CI

    Also update gofmt, some outdated patterns.
    arp242 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f830802 View commit details
    Browse the repository at this point in the history
  2. Fix race in test

    ==================
    WARNING: DATA RACE
    Write at 0x00c000394018 by goroutine 10:
      github.com/fsnotify/fsevents.TestIssue48()
          /Users/runner/work/fsevents/fsevents/fsevents_test.go:137 +0xcc6
      testing.tRunner()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f
      testing.(*T).Run·dwrap·21()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x47
    
    Previous read at 0x00c000394018 by goroutine 12:
      github.com/fsnotify/fsevents.TestIssue48.func1()
          /Users/runner/work/fsevents/fsevents/fsevents_test.go:112 +0x1d2
    
    Goroutine 10 (running) created at:
      testing.(*T).Run()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x726
      testing.runTests.func1()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1598 +0x99
      testing.tRunner()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f
      testing.runTests()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1596 +0x7ca
      testing.(*M).Run()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1504 +0x9d1
      main.main()
          _testmain.go:55 +0x22b
    
    Goroutine 12 (finished) created at:
      github.com/fsnotify/fsevents.TestIssue48()
          /Users/runner/work/fsevents/fsevents/fsevents_test.go:107 +0x815
      testing.tRunner()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f
      testing.(*T).Run·dwrap·21()
          /Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x47
    ==================
    arp242 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    61ccd0a View commit details
    Browse the repository at this point in the history
  3. Run tests 10 times to catch flaky tests

    Experience with fsnotify has shown this can be an issue, and the tests
    here seem fast enough.
    arp242 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ce9aad4 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    1e71d45 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    f73112e View commit details
    Browse the repository at this point in the history
Loading