fix(docker): add git safe dir to data dir #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josef Andersson <josef.andersson@gmail.com>
|
Many thanks @janderssonse for bringing this issue up and providing a fix right away. I tested this locally and all seems to work as expected again using your fix. |
carmenbianca
added a commit
to carmenbianca/reuse-tool
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca
added a commit
to carmenbianca/reuse-tool
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the requirement that: Newer versions of git needs the 'git config --global --add safe.directory /data' setting to work in a container.
Here is an example to verify both the problem and the fix:
Problem:
docker build -f docker/Dockerfile-debian -t reusetest_default .2). Run the code in reuse compliant project, I used my script project (https://github.com/janderssonse/janderscripts)
docker run --rm --volume $(pwd):/data reusetest_default lintResult: Fails respecting .gitignore etc as the git config will fail and show warning '---no VCS'' etc.
Fix:
3). Now try the same dockerfile but with the added fix in this pr:
docker build -f docker/Dockerfile-debian -t reusetest_with_git_add_data_safe .4). Run on same example repo as before (https://github.com/janderssonse/janderscripts)
docker run --rm --volume $(pwd):/data reusetest_with_git_add_data_safe lintResult: success - git (vcs) accepted, .gitignore respected etc.