Skip to content

Conversation

mxmehl
Copy link
Member

@mxmehl mxmehl commented Mar 13, 2023

Fix #693

gettext (msgfmt) was missing from the Docker images during build. This PR adds gettext during the setup phase. The actual Docker image size will not significantly be impacted as it's a multistage build.

@mxmehl mxmehl requested a review from carmenbianca March 13, 2023 14:00
@mxmehl mxmehl force-pushed the fix-docker-msgfmt branch from 098f5ad to e32db6a Compare March 13, 2023 14:02
@mxmehl mxmehl force-pushed the fix-docker-msgfmt branch from e32db6a to 0499e7d Compare April 5, 2023 12:57
@linozen
Copy link
Contributor

linozen commented Apr 5, 2023

LGTM 👍

@linozen linozen merged commit 71f76cb into main Apr 5, 2023
@mxmehl mxmehl deleted the fix-docker-msgfmt branch April 5, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gettext translations not included in Alpine Docker image
2 participants