Drop Python 3.6 support #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48a58be to
3363cbd
Compare
bef3a8a to
8b3fd05
Compare
I've also removed the RTD theme dependency. For some reason, its 'sphinxcontrib.jquery' dependency caused an infinite loop in Poetry. I spent far more time than I care for trying to fix this, so I've just given up now. Alabaster is (or: has become) a decent theme. Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
73f156d to
36f1e64
Compare
Let's try to be a little green and run fewer tests. Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
36f1e64 to
4d52f01
Compare
nicorikken
reviewed
Feb 17, 2023
nicorikken
approved these changes
Feb 17, 2023
|
@carmenbianca in the future we'll get to reap more of the tooling benefits 🤞 |
|
Thanks @nicorikken ! we can already re-enable pytest coverage after this PR :) |
carmenbianca
added a commit
to carmenbianca/reuse-tool
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca
added a commit
to carmenbianca/reuse-tool
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #530
This was surprisingly annoying. I thought Poetry was supposed to make life easier 😩 I'm stuck using Poetry v1.1 to maintain
poetry-core>=1.0.0support, and it doesn't work quite as smoothly as later versions. Specifically, there was an endless loop forsphinxcontrib.jquery, which means I had to drop the RTD theme to preserve my patience for more important things.