Rework documentation deployment #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.readthedocs.yaml
Outdated
Comment on lines
7
to
10
| build: | ||
| os: "ubuntu-22.04" | ||
| tools: | ||
| python: "3.10" |
There was a problem hiding this comment.
This should probably mirror our CI configuration, which uses 20.04 and Python 3.6, with a comment stating that these two should be identical.
There was a problem hiding this comment.
Of course, that makes sense. Fix incoming.
|
|
||
| python: | ||
| install: | ||
| - requirements: docs/requirements.txt |
There was a problem hiding this comment.
Was this file generated? Can you add a comment stating which command was used to generate the file?
There was a problem hiding this comment.
For sure :) I was thinking of adding the command also to the make docs make instructions.
There was a problem hiding this comment.
I did add it to make docs and created a separate make docs-ci to only run the sphinx build command when testing the generation process in the CI workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.