Skip to content

Refactoring: Use the mixin mediaquery instead of the global _mq.scss #173

@philipbrembeck

Description

@philipbrembeck

We do have a non-working mixing defined, but we could use the mixin from SCSS-Scratch:

/* MEDIA QUERY Mixin */
@mixin mq($size) {
  @if $size == phone {
    @media (max-width:48rem) { @content; }
  }
  @else if $size == s-tablet {
    @media (max-width:50rem) { @content; }
  } 
  @else if $size == tablet {
    @media (max-width:64rem) { @content; }
  } 
  @else if $size == s-desktop {
    @media (max-width:104rem) { @content; }
  }
  @else if $size == desktop {
    @media (min-width:75rem) { @content; }
  }
}

We would have to define our own break-points, but that would make the SCSS more readable and accessible.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions