Skip to content

Add /weekly and /monthly to Telegram (#5527) #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 6, 2021
Merged

Add /weekly and /monthly to Telegram (#5527) #5846

merged 13 commits into from
Nov 6, 2021
+452 −11

Conversation

Merinorus
Copy link
Contributor

@Merinorus Merinorus commented Nov 5, 2021 •
edited by xmatthias
Loading

Summary

Add /weekly and /monthly commands to Telegram RPC

Closes #5527 show average profit in overwiew (more or less)

Quick changelog

  • /weekly shows profit & loss the last n ISO weeks (starting from Monday)
  • /monthly shows profit & loss the last n months

What's new?

/weekly

Weekly Profit over the last 8 weeks (starting from Monday):
Monday      Profit BUSD    Profit EUR    Trades
----------  -------------  ------------  --------
2021-11-01  0.000 BUSD     0.000 EUR     0 trades
2021-10-25  0.000 BUSD     0.000 EUR     0 trades
2021-10-18  0.000 BUSD     0.000 EUR     0 trades
2021-10-11  0.000 BUSD     0.000 EUR     0 trades
2021-10-04  0.000 BUSD     0.000 EUR     0 trades
2021-09-27  0.000 BUSD     0.000 EUR     0 trades
2021-09-20  0.000 BUSD     0.000 EUR     0 trades
2021-09-13  0.000 BUSD     0.000 EUR     0 trades


/monthly

Monthly Profit over the last 6 months:
Month    Profit BUSD    Profit EUR    Trades
-------  -------------  ------------  --------
2021-11  0.000 BUSD     0.000 EUR     0 trades
2021-10  0.000 BUSD     0.000 EUR     0 trades
2021-09  0.000 BUSD     0.000 EUR     0 trades
2021-08  26.109 BUSD    22.621 EUR    1 trades
2021-07  -0.591 BUSD    -0.512 EUR    1 trades
2021-06  0.000 BUSD     0.000 EUR     0 trades

@Merinorus
WIP Add /weekly and /monthly to Telegram RPC
ffc2de8 
Related to "Show average profit in overview" (freqtrade#5527)

Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
Add /weekly and /monthly to Telegram RPC
15616d7 
/weekly now list weeks starting from monday instead of rolling weeks.
/monthly now list months starting from the 1st.

Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
/weekly and /monthly documentation
a8651b0 
Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
WIP Add /weekly and /monthly to Telegram RPC
5f40158 
Related to "Show average profit in overview" (freqtrade#5527)

Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
Add /weekly and /monthly to Telegram RPC
459ff96 
/weekly now list weeks starting from monday instead of rolling weeks.
/monthly now list months starting from the 1st.

Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
/weekly and /monthly documentation
87634f0 
Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
Test /monthly & clean
7025325 
Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
Merge remote-tracking branch 'origin/5527-show_average_profit_in_over…
77f3dab 
…wiew' into 5527-show_average_profit_in_overwiew

# Conflicts:
#	freqtrade/rpc/rpc.py
#	requirements.txt
#	tests/rpc/test_rpc_telegram.py
@Merinorus
Fix missing CallbackQueryHandler
8eabdd6 
Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@Merinorus
Remove line breaks
da4344d 
Signed-off-by: Antoine Merino <antoine.merino.dev@gmail.com>
@coveralls
Copy link

coveralls commented Nov 6, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 98.018% when pulling d0e192e on Merinorus:5527-show_average_profit_in_overwiew into d99eacc on freqtrade:develop.

xmatthias
xmatthias reviewed Nov 6, 2021
View reviewed changes
Copy link
Member

@xmatthias xmatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR already.
I've only had a quick look (will have to try this later) ... but it looks already pretty good!

@Merinorus
Copy link
Contributor Author

Merinorus commented Nov 6, 2021 •
edited
Loading

All good for me!

@xmatthias xmatthias added the RPC Telegram, ReST API, external control, ... label Nov 6, 2021
xmatthias
xmatthias approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@xmatthias xmatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me!

For me too 👍

this is a great new feature - looking forward to using it already!

@xmatthias xmatthias merged commit 66220d6 into freqtrade:develop Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmatthias xmatthias xmatthias approved these changes

Assignees
No one assigned
Labels
RPC Telegram, ReST API, external control, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show average profit in overview
3 participants
@Merinorus @coveralls @xmatthias