Skip to content

docker: unclutter dockerfile #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

docker: unclutter dockerfile #196

merged 2 commits into from
Aug 1, 2025

Conversation

GoliathLabs
Copy link
Contributor

Description

Edit the Dockerfile and remove any unnecessary steps, as the npm audit command should not be required. This should be done in a development environment instead.

Motivation and Context

How Has This Been Tested?

Screenshots/links:

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

@GoliathLabs GoliathLabs changed the title [BUGFIX] chore: unclutter dockerfile docker: unclutter dockerfile Aug 1, 2025
@GoliathLabs GoliathLabs mentioned this pull request Aug 1, 2025
Open
3 tasks
maurerle
maurerle approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the "build" image is dropped anyway, using "apt-get clean" is not that useful - the nginx image stays clean anyway.

But it does not hurt either, the rest looks very good!

@maurerle maurerle merged commit 53989c9 into freifunk:main Aug 1, 2025
2 checks passed
@GoliathLabs GoliathLabs deleted the patch-1 branch August 1, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurerle maurerle maurerle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoliathLabs @maurerle