Skip to content

Conversation

aligator
Copy link
Collaborator

@aligator aligator commented May 4, 2025

Description

Fixes filtering the statistic list and removing the filter (#152)

Similar problem as #149 , #137.

Patches the dom element only the first time. after that it patches the previous vnode.

Motivation and Context

Closes #152

How Has This Been Tested?

Tested FF, Chrome - Mobile and desktop

Screenshots/links:

Before:
Clicking on "11" and then remove the filter again: (
image
)

image

After:
image

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

…ifunk#152)

Also fixes the table to be loaded correctly when the filter is removed again.

Similar problem as freifunk#149 , freifunk#137.

Patches the dom element only the first time. after that it patches the previous vnode.
@aligator aligator force-pushed the 152-fix-filter-statistic branch from 0048dd2 to 358b23c Compare May 4, 2025 10:01
@rotanid rotanid self-assigned this May 4, 2025
@rotanid rotanid added the javascript Pull requests that update Javascript code label May 4, 2025
@aligator aligator marked this pull request as draft May 4, 2025 20:47
@aligator aligator marked this pull request as ready for review May 27, 2025 18:17
@rotanid rotanid merged commit 41b6019 into freifunk:main May 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filtering via statistics is broken
2 participants