[BUGFIX] sorting of sortable tables. (#137) #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar problem as freifunk#149. However I think I understand it now better: the example on https://github.com/snabbdom/snabbdom describes that the first patch should be on the dom-element, but the second patch should be on the vnode from before. So it now saves the last vnode and patch it. Only on the first patch (if vnode is not set yet), it patches the element.
|
fixing the bug confirmed by local testing on my laptop, thanks! cc @skorpy2009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar problem as #149.
However I think I understand it now better:
the example on https://github.com/snabbdom/snabbdom describes that the first patch should be on the dom-element, but the second patch should be on the vnode from before.
So it now saves the last vnode and patch it. Only on the first patch (if vnode is not set yet), it patches the element.
Motivation and Context
Closes #137
How Has This Been Tested?
FF and chrome, mobile and desktop tested
Screenshots/links:
Checklist: