[TASK] add attribution of device-pictures to about page #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyIgel
requested changes
Oct 5, 2023
|
@maurerle please rebase |
Text is translatable in different languages with configurable source and license
|
Thanks, I rebased and added the suggestions from @MyIgel - and did run And I tested this for the FFAC config, which works fine |
skorpy2009
approved these changes
Oct 11, 2023
|
@MyIgel is there anything still needed to do here? |
|
I don't think so, just had not enough time to have a last look ^^ |
MyIgel
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds attribution of the hardware images to the about page.
A rename from hwImg to device_pictures is done.
It is possible to change to a custom attribution if a different source of pictures is taken.
Motivation and Context
The CC-BY-NC-SA 4.0 requires to attribute the creators.
As we are all not lawyers this is a first step into this direction.
I do not think that it is required to attribute per picture, but we should make such information available in the https://github.com/freifunk/device-pictures repository.
How Has This Been Tested?
See https://map.aachen.freifunk.net/
Screenshots/links:
Checklist: