Minor improvements on the GUI/CLI #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand line help is displayed
|
Can you fix it in color manager? Sorry for the GUI language is Chinese, it is a bug for v1.6.1, the command argument -l en is not working. |
|
I can try. However, how do I get there? :) which menu is this one? Update: Ah it is |
|
Pushed, here is the result. Better? |
|
There were a lot of extra whitespaces at the end of the lines. I had to clean them to make it easier to work on this in the future. |
Excellent!!! |
|
Great work, thank you guys!
I'm abroad right now with very limited access, so I'm not able to review
and merge it until the very end of June.
Sorry about that, and thanks for your patience!
|
|
@andrasfuchs no problem dude, take your time! |
andrasfuchs
requested changes
Jul 4, 2022
|
Did I cover all the requested items? |
|
Yes, looks great, I'm going to merge it now. |
andrasfuchs
approved these changes
Jul 4, 2022
|
Nice. Now with the code a bit cleaner it would be better for contributors. I also suggest to pass a formatter if it was not done in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue, #116
Some screenshots
Initial window (improved making the output field more visible)
Fixed the Right toolbar in the main window
Settings window. Improved title and rulers
Command line help improved
