Add CPU and Memory usage metric column for pods view #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanCheo
commented
May 25, 2025
...ges/core/src/renderer/components/workloads-pods/columns/pods-cpu-usage-column.injectable.tsx
Outdated
Show resolved
Hide resolved
|
Does it really work? I have EKS cluster and I see N/A: |
|
@dex4er sorry last commit is fixed it |
|
@HanCheo, any idea why the sorting is not working for all pods? |
|
@arnaud-dezandee done! |
|
@HanCheo This is great. I confirm it really works. |
|
So this is ready to merge I think? |
arnaud-dezandee
approved these changes
May 25, 2025
|
@dex4er yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw PR #181, but it hasn’t been updated since then.
So I’ve created a new one.
Screenshot of the current state:
Here’s what it looks like when the metrics-server isn't working:
this will close #743