Skip to content

Correct dependencies for electron and pnpm #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

Correct dependencies for electron and pnpm #688

merged 3 commits into from
May 5, 2025

Conversation

dex4er
Copy link
Collaborator

@dex4er dex4er commented May 5, 2025 •
edited
Loading

Fixes https://github.com/freelensapp/freelens-nightly-builds/actions/runs/14828260056/job/41635400364

Description of changes:

  • electron is put to devDependencies
  • pnpm is put runtime dependencies for package/core
  • Knip is tweaked for exceptions
  • patch for circular-dependency-plugin hides annoying warning in Knip

@dex4er dex4er changed the title Fix/dependencies Electron is removed from runtime dependencies May 5, 2025
@dex4er dex4er changed the title Electron is removed from runtime dependencies Electron removed from runtime dependencies May 5, 2025
@dex4er dex4er self-assigned this May 5, 2025
@dex4er dex4er added bug Something isn't working regression Worked before labels May 5, 2025
@dex4er dex4er changed the title Electron removed from runtime dependencies Correct dependencies for electron and pnpm May 5, 2025
@dex4er dex4er merged commit 5581d4a into freelensapp:main May 5, 2025
8 checks passed
@dex4er dex4er deleted the fix/dependencies branch May 5, 2025 13:27
@dex4er dex4er added this to the v1.3.0 milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dex4er dex4er

Labels
bug Something isn't working regression Worked before
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@dex4er