Skip to content

Conversation

surajshetty3416
Copy link
Member

@surajshetty3416 surajshetty3416 commented Jul 8, 2025

State Styles

To handle hover, focus, and active styles for individual properties.
Also, added properties to quickly add transition on a block.

Screen.Recording.2025-07-08.at.3.47.42.PM.mov
  • Introduced a generic "StyleControl" that can handle state styles for any property handled by different controls like Color, OptionToggle, Autocomplete, etc. Just need to pass the main control to this control with few props to extend the state style functionality.

Other

Indicate cascaded style value as placeholder

Screenshot 2025-07-08 at 3 51 36 PM Screenshot 2025-07-08 at 3 51 24 PM

Previously, when users attempted to remove a property value that was cascaded from a different breakpoint, the value would remain visible. This led to confusion, as users expected the property to be removed but it was actually inherited from elsewhere.
To avoid this confusion, indicate the cascaded value using a placeholder instead of displaying it as an actual value. This visually differentiates inherited styles from explicitly defined ones, making it clear to users that the value is not directly set at the current breakpoint.

Range input

And opacity property

Screen.Recording.2025-07-08.at.4.01.11.PM.mov

Next:
Audit for style properties that possibly will never have state styles

- Refactor getMargin and getPadding logic
- Use cascading style to set as placeholder to indicate cascaded style from other breakpoints
- This control just needs style property. Everything else like fetching cascaded values,  updating values, and state styles (will be added) is handled inside this control
@surajshetty3416 surajshetty3416 marked this pull request as ready for review July 8, 2025 10:38
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.85%. Comparing base (790db7e) to head (af98896).
Report is 46 commits behind head on develop.

Files with missing lines Patch % Lines
...ilder/builder/doctype/builder_page/builder_page.py 69.56% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #377      +/-   ##
===========================================
+ Coverage    40.81%   40.85%   +0.04%     
===========================================
  Files           16       16              
  Lines         1252     1258       +6     
===========================================
+ Hits           511      514       +3     
- Misses         741      744       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416 surajshetty3416 merged commit 799ef31 into develop Jul 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant