-
Notifications
You must be signed in to change notification settings - Fork 273
feat: State styles #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: State styles #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor getMargin and getPadding logic - Use cascading style to set as placeholder to indicate cascaded style from other breakpoints
- This control just needs style property. Everything else like fetching cascaded values, updating values, and state styles (will be added) is handled inside this control
…text via bubble menu
Also, introduced input inside color picker to manually set hash of color
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #377 +/- ##
===========================================
+ Coverage 40.81% 40.85% +0.04%
===========================================
Files 16 16
Lines 1252 1258 +6
===========================================
+ Hits 511 514 +3
- Misses 741 744 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State Styles
To handle hover, focus, and active styles for individual properties.
Also, added properties to quickly add transition on a block.
Screen.Recording.2025-07-08.at.3.47.42.PM.mov
Other
Indicate cascaded style value as placeholder
Previously, when users attempted to remove a property value that was cascaded from a different breakpoint, the value would remain visible. This led to confusion, as users expected the property to be removed but it was actually inherited from elsewhere.
To avoid this confusion, indicate the cascaded value using a placeholder instead of displaying it as an actual value. This visually differentiates inherited styles from explicitly defined ones, making it clear to users that the value is not directly set at the current breakpoint.
Range input
And opacity property
Screen.Recording.2025-07-08.at.4.01.11.PM.mov
Next:
Audit for style properties that possibly will never have state styles