fix!: use check_nested_command, drop python 3.9 #1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also pin the click version. |
|
Should we pin it to 8.2.0 or the 8.1.8 |
revant
approved these changes
May 11, 2025
|
I guess |
4 tasks
Closed
|
Shall we follow click in dropping support for python3.9? I'd say yes. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I think the easy install check fails because the error that this PR tries to fix is part of the latest docker image that is used in the test case. So the failure should be safe to ignore. |
v14+ requires py310+, so seems fine |
|
🎉 This PR is included in version 5.25.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced May 12, 2025
asaura08
added a commit
to asaura08/press
that referenced
this pull request
May 12, 2025
Summary:
This pull request addresses an issue where the bench CLI fails to initialize a new bench due to an incompatibility with the click package. The _check_multicommand import used in bench is no longer available in newer versions of click.
Changes Introduced:
Pins click to version 8.1.3 to ensure compatibility with bench.
Updates Dockerfile/environment setup to include the fixed click version before installing bench.
Reason for Change:
Without this fix, running bench init throws an ImportError, breaking the build and preventing Frappe environments from being initialized properly.
frappe/bench#1632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click released a new version 8.2.0
It doesnt have the _check_multicommand function as it has been renamed
Ref https://github.com/pallets/click/blob/8.2.0/src/click/core.py
pip install frappe-benchfails because of thisCaution
This PR drops support for python3.9.