feat(bench): miscellaneous improvements for pkg-config #1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80615ec to
a77c126
Compare
gavindsouza
reviewed
Mar 24, 2025
e16d34e to
fad6abf
Compare
pkg-config before trying to setup bench…p bench Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
4df98ac to
898ec00
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces miscellaneous improvements for the bench tool including dependency checks for pkg-config on macOS and updates pip install commands. Key changes include:
- Adding helper functions (get_mariadb_pkgconfig_path and check_pkg_config) to manage pkg-config configuration.
- Modifying Base.run to accept an env parameter and updating pip install command invocations in multiple modules.
- Updating CI workflow to ensure pkg-config is installed.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bench/utils/system.py | Introduces helper functions for pkg-config checking and configuration. |
| bench/bench.py | Updates the run method signature to include env; adds environment handling for pip install commands. |
| bench/app.py | Adjusts pip install commands to pass the environment configuration for macOS. |
| .github/workflows/ci.yml | Updates CI configuration to install pkg-config along with redis-server. |
Comments suppressed due to low confidence (1)
bench/bench.py:382
- The PR description mentions passing '--use-pep517' to pip install, but this flag is not present in the pip install commands. Please update these commands to include '--use-pep517' if intended.
self.run(f"{self.bench.python} -m pip install {quiet_flag} --upgrade -e {frappe}", cwd=self.bench.name, env=env)
898ec00 to
8848c42
Compare
8848c42 to
cda543b
Compare
|
Everything should be fine, it is when I ssh in and manually run the commands, just pip install within the test suite can't find pkg-config somehow, which shouldn't be related to this PR. Edit: |
cda543b to
191e0bc
Compare
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
|
akhilnarang
added a commit
that referenced
this pull request
May 11, 2025
* upstream/develop: ci: drop support for python 3.9 chore: pin Click version fix: use check_nested_command feat(bench): miscellaneous improvements for pkg-config (#1622) Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang
added a commit
that referenced
this pull request
May 11, 2025
* upstream/staging: ci: drop support for python 3.9 chore: pin Click version fix: use check_nested_command feat(bench): miscellaneous improvements for pkg-config (#1622) Signed-off-by: Akhil Narang <me@akhilnarang.dev>
|
🎉 This PR is included in version 5.25.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg-configis installedPKG_CONFIG_PATHfor macOS