Fix Console error page & logging page on framework startup error #9133
+48
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsens
reviewed
Jun 12, 2025
Comment on lines
25
to
42
| private readonly onErrorAllowedLinks: Link[] = [ | ||
| { | ||
| name: 'getFileContent', | ||
| rel: 'logging', | ||
| description: 'view or download a (log)file', | ||
| href: 'http://localhost:8080/iaf-test/iaf/api/file-viewer', | ||
| type: 'GET', | ||
| roles: ['IbisObserver', 'IbisDataAdmin', 'IbisAdmin', 'IbisTester'], | ||
| }, | ||
| { | ||
| name: 'getLogDirectory', | ||
| rel: 'logging', | ||
| description: 'view files/folders inside the log directory', | ||
| href: 'http://localhost:8080/iaf-test/iaf/api/logging', | ||
| type: 'GET', | ||
| roles: ['IbisObserver', 'IbisDataAdmin', 'IbisAdmin', 'IbisTester'], | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Maybe it would be nicer to use a partial for the Link so it would not need all the (kind of incorrect?) metadata.
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the console error page and logging page issues encountered during framework startup errors. Key changes include updating error handling in the ErrorComponent, enhancing error recovery in the AuthService, and adopting updated Angular syntax in the ToastsContainerComponent.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| console/frontend/src/main/frontend/src/app/views/error/error.component.ts | Updated dependency injection and error handling method signature in ErrorComponent. |
| console/frontend/src/main/frontend/src/app/services/auth.service.ts | Added fallback links for error handling and updated permissions subscription callback. |
| console/frontend/src/main/frontend/src/app/guards/auth.guard.ts | Minor cleanup in the auth guard logic. |
| console/frontend/src/main/frontend/src/app/components/toasts-container/toasts-container.component.html | Updated Angular 17 control flow syntax (@for). |
| console/frontend/src/main/frontend/src/app/components/file-viewer/file-viewer.component.ts | Enhanced error parsing logic and introduced an unused import. |
console/frontend/src/main/frontend/src/app/views/error/error.component.ts
Outdated
Show resolved
Hide resolved
console/frontend/src/main/frontend/src/app/components/file-viewer/file-viewer.component.ts
Outdated
Show resolved
Hide resolved
49029da to
7b4b7db
Compare
philipsens
approved these changes
Jun 18, 2025
…tems-api-endpoint-can-be-reached
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.