Sort processing receivers statistics based on thread name #9181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthbo
commented
Jun 20, 2025
There was a problem hiding this comment.
I only removed
@if (adapter) {
...
}
which was wrapping all of the html, and update the indenting on every line
|
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the readability and reliability of the UI components by sorting processing receiver statistics based on their thread name and by standardizing type definitions and HTML formatting.
- Updated adapter-status components to use non-null assertions and refined HTML formatting for consistency.
- Exported the StatisticsKeeper type and added a helper method to sort processing threads alphabetically.
- Enhanced iteration tracking in adapterstatistics HTML templates for clearer identification of list items.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| console/frontend/src/main/frontend/src/app/views/status/adapter-status/adapter-status.component.ts | Changed adapter from nullable to non-nullable using the non-null assertion operator. |
| console/frontend/src/main/frontend/src/app/views/status/adapter-status/adapter-status.component.html | Streamlined HTML formatting and removed redundant code. |
| console/frontend/src/main/frontend/src/app/views/adapterstatistics/adapterstatistics.service.ts | Exported the StatisticsKeeper type for broader usage. |
| console/frontend/src/main/frontend/src/app/views/adapterstatistics/adapterstatistics.component.ts | Introduced getSortedProcessingThreads() to sort threads by name. |
| console/frontend/src/main/frontend/src/app/views/adapterstatistics/adapterstatistics.component.html | Updated @for loops to use clearer tracking by unique thread names and pipe name. |
philipsens
reviewed
Jun 23, 2025
Comment on lines
29
to
30
| @Input({ required: true }) loadFlowInline = true; | ||
| @Input({ required: true }) adapterShowContent: Record<string, boolean> = {}; |
There was a problem hiding this comment.
Kan je dit niet ook gelijk doen dan?
philipsens
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.