Add parameters to ExceptionPipe and update ErrorMessageFormatter to apply them #9165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsm5
reviewed
Jun 17, 2025
| */ | ||
| public class PipeRunException extends IbisException { | ||
|
|
||
| private @Getter IPipe pipeInError = null; | ||
| private final @Getter IPipe pipeInError; | ||
| private final @Getter Map<String, Object> parameters; |
There was a problem hiding this comment.
Het ziet er goed uit volgens mij, ik zie veel mogelijkheden. Wel vraag ik mij af of het verstanding is om een Object mee te geven in plaats van een String?
There was a problem hiding this comment.
De map ParameterValueList#getValueMap() heeft als type-signature Map<String, Object>. Vandaar dat deze dat ook heeft.
evandongen
approved these changes
Jun 19, 2025
nielsm5
reviewed
Jun 20, 2025
| </EchoPipe> | ||
|
|
||
| <ExceptionPipe name="result-count=0" copyParametersToSession="true"> | ||
| <Param name="errorCode" value="-1"/> |
nielsm5
approved these changes
Jun 22, 2025
evandongen
approved these changes
Jun 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.