Remove silly formatException class from MessageHandler #9144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsm5
commented
Jun 15, 2025
Comment on lines
+121
to
+129
| // The ApplicationContext is practically always an Adapter except when the listener is created directly via the LarvaScenarioContext | ||
| private Message formatExceptionUsingErrorMessageFormatter(PipeLineSession session, Message inputMessage, Throwable t) { | ||
| if (applicationContext instanceof Adapter adapter) { | ||
| return adapter.formatErrorMessage(null, t, inputMessage, session, null); | ||
| } | ||
|
|
||
| log.warn("unformatted exception while processing input request [{}]", inputMessage, t); | ||
| return new Message(t.getMessage()); | ||
| } |
There was a problem hiding this comment.
Although over here we can safely assume the ApplicationContext is always an Adapter, I've copied this block from the JavaListener.
nielsm5
commented
Jun 15, 2025
| @@ -177,7 +178,7 @@ private Message processRequest(@Nonnull MessageWrapper<M> messageWrapper, @Nonnu | |||
| } catch (ListenerException e) { | |||
| // Message with error contains a String so does not need to be preserved. | |||
| // (Trying to preserve means dealing with extra IOException for which there is no reason here) | |||
| return handler.formatException(null, session, message, e); | |||
| return formatExceptionUsingErrorMessageFormatter(session, message, e); | |||
There was a problem hiding this comment.
I think this is quite strange, this listener should always just throw the exception, it's up to the callee to format it using the correct ErrorMessageFormatter if any.
nielsm5
commented
Jun 16, 2025
| */ | ||
| Message processRequest(IListener<M> origin, RawMessageWrapper<M> rawMessage, Message message, PipeLineSession session) throws ListenerException; | ||
| Message processRequest(IPushingListener<M> origin, RawMessageWrapper<M> rawMessage, Message message, PipeLineSession session) throws ListenerException; |
There was a problem hiding this comment.
I agree this ain't perfect, but for now we are limiting the code-execution flow in implementing to call the correct 'entrypoint' for the receiver.
tnleeuw
approved these changes
Jun 20, 2025
|
Initially looks good except a stupid test that fails! |
|
evandongen
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.