-
Notifications
You must be signed in to change notification settings - Fork 81
Add JsonPathPipe #9143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JsonPathPipe #9143
Conversation
Just some thoughts; What can you do with this pipe that you can't do using a Or is this meant to 'beautify' the above construction? |
This is indeed meant to be a more obvious alternative for that construction. |
Okay, thanks for the comment :) Another little advantage is that you don't have to persist the message for the entire session, either in mem or on disk, could be beneficial! EDIT: I do see a preserve tho, not sure how that exactly behaves, i might be wrong in above statement |
* <tr> | ||
* <td>{@code $.*.a}</td> | ||
* <td> | ||
* <pre><code> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik denk dat dit in <pre>{@code .... }</pre>
moet zijn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik weet niet goed hoe het er uit gaat zien in de "echte" Frank!Doc maar dit was makkelijker netjes te krijgen in de IntelliJ JavaDoc preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik zou dit wel graag gelijk houden met de rest van de codebase, eerder hebben we dit namelijk allemaal rechtgetrokken. Zie ook https://github.com/frankframework/frankframework/blob/master/AdditionalCodingGuidelines.md (Documentation, onderaan)
private JsonPath validateJsonPathExpression(String jsonPathExpression) throws ConfigurationException { | ||
try { | ||
return JsonPath.compile(jsonPathExpression); | ||
} catch (com.jayway.jsonpath.InvalidPathException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan je deze niet gewoon importeren?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja, natuurlijk wel. Ik had het zo uitgeschreven om makkelijker de goede exception te vinden in code-completion, en daarna vergeten om ze ook te importeren.
|
No description provided.