Skip to content

Conversation

tnleeuw
Copy link
Contributor

@tnleeuw tnleeuw commented Jun 13, 2025

No description provided.

@tnleeuw tnleeuw requested review from evandongen and nielsm5 June 13, 2025 13:41
@tnleeuw tnleeuw self-assigned this Jun 13, 2025
@tnleeuw tnleeuw added the JSON label Jun 13, 2025
@tnleeuw tnleeuw linked an issue Jun 13, 2025 that may be closed by this pull request
@Laurens-makel
Copy link
Contributor

Laurens-makel commented Jun 13, 2025

Just some thoughts;

What can you do with this pipe that you can't do using a JsonParameter within a PutInSessionPipe (and potentially a getInputFromSessionKey attribute on the next pipe)?

Or is this meant to 'beautify' the above construction?

@tnleeuw
Copy link
Contributor Author

tnleeuw commented Jun 13, 2025

Just some thoughts;

What can you do with this pipe that you can't do using a JsonParameter within a PutInSessionPipe (and potentially a getInputFromSessionKey attribute on the next pipe)?

Or is this meant to 'beautify' the above construction?

This is indeed meant to be a more obvious alternative for that construction.

@Laurens-makel
Copy link
Contributor

Laurens-makel commented Jun 13, 2025

Just some thoughts;
What can you do with this pipe that you can't do using a JsonParameter within a PutInSessionPipe (and potentially a getInputFromSessionKey attribute on the next pipe)?
Or is this meant to 'beautify' the above construction?

This is indeed meant to be a more obvious alternative for that construction.

Okay, thanks for the comment :)

Another little advantage is that you don't have to persist the message for the entire session, either in mem or on disk, could be beneficial!

EDIT: I do see a preserve tho, not sure how that exactly behaves, i might be wrong in above statement

* <tr>
* <td>{@code $.*.a}</td>
* <td>
* <pre><code> {
Copy link
Contributor

@evandongen evandongen Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik denk dat dit in <pre>{@code .... }</pre> moet zijn

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik weet niet goed hoe het er uit gaat zien in de "echte" Frank!Doc maar dit was makkelijker netjes te krijgen in de IntelliJ JavaDoc preview.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik zou dit wel graag gelijk houden met de rest van de codebase, eerder hebben we dit namelijk allemaal rechtgetrokken. Zie ook https://github.com/frankframework/frankframework/blob/master/AdditionalCodingGuidelines.md (Documentation, onderaan)

@tnleeuw tnleeuw requested a review from evandongen June 16, 2025 12:12
private JsonPath validateJsonPathExpression(String jsonPathExpression) throws ConfigurationException {
try {
return JsonPath.compile(jsonPathExpression);
} catch (com.jayway.jsonpath.InvalidPathException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan je deze niet gewoon importeren?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, natuurlijk wel. Ik had het zo uitgeschreven om makkelijker de goede exception te vinden in code-completion, en daarna vergeten om ze ook te importeren.

Copy link

@nielsm5 nielsm5 merged commit a7f71c8 into master Jun 17, 2025
35 checks passed
@nielsm5 nielsm5 deleted the feature/8336_JsonPathPipe branch June 17, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JsonPathPipe for oneliner JSON data extraction
4 participants