Fix MQTT resources #9025
Merged
Fix MQTT resources #9025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsm5
commented
May 21, 2025
| @@ -58,14 +59,12 @@ protected MqttClient map(MqttClientSettings data) { | |||
|
|
|||
| String clientId = data.getClientId(); | |||
| if (StringUtils.isEmpty(clientId)) { | |||
| clientId = AppConstants.getInstance().getProperty("transactionmanager.uid"); | |||
| clientId = Misc.getHostname()+"-"+ UUIDUtil.createSimpleUUID(); | |||
There was a problem hiding this comment.
Not always set, so it was an unreliable property...
nielsm5
commented
May 21, 2025
Comment on lines
+65
to
+67
| MqttClient client = new MqttClient(data.geturl(""), clientId, getMqttDataStore(data.getPersistenceDirectory())); | ||
| client.connect(connectOptions); | ||
| return client; |
nielsm5
commented
May 21, 2025
| @@ -87,7 +88,8 @@ protected O map(P object) { | |||
| * If not cached yet, attempts to traverse all {@link IObjectLocator IObjectLocators} to do so. | |||
| */ | |||
| protected final O get(String name, Properties environment) { | |||
| return objects.computeIfAbsent(name, k -> compute(k, environment)); | |||
| String nameWithResourcePrefix = StringUtils.prependIfMissing(name, resourcePrefix+"/"); | |||
There was a problem hiding this comment.
Allow omitting the default resource prefix.
tnleeuw
approved these changes
May 21, 2025
|
nielsm5
added a commit
that referenced
this pull request
May 22, 2025
(cherry picked from commit f2b32cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.