Introduce a SoapAction ServiceListener #9077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evandongen
reviewed
Jun 2, 2025
| * <li>SOAP protocol is stored under a session key 'soapProtocol'</li> | ||
| * <li>SOAP action is stored under a session key 'SOAPAction'</li> | ||
| * </ul> | ||
| * and for each response a multipart message is constructed if a 'multipart'-XML is provided in sessionKey specified by multipartXmlSessionKey. |
There was a problem hiding this comment.
Suggested change
| * and for each response a multipart message is constructed if a 'multipart'-XML is provided in sessionKey specified by multipartXmlSessionKey. | |
| * and for each response a multipart message is constructed if a 'multipart'-XML is provided in sessionKey specified by {@code multipartXmlSessionKey}. |
| */ | ||
| public class SoapActionServiceListener extends PushingListenerAdapter implements HasPhysicalDestination { | ||
|
|
||
| private final @Getter String domain = "Http"; |
There was a problem hiding this comment.
Suggested change
| private final @Getter String domain = "Http"; | |
| private static final @Getter String domain = "Http"; |
edit: maar wordt helemaal niet gebruikt?
There was a problem hiding this comment.
Tja, dit is iets dat in een interface zit, en wordt gebruikt voor de console, zie https://example.frankframework.org/#/connections.
Idealieter is dit een annotatie oid en niet een stom veld...
core/src/main/java/org/frankframework/http/SoapActionServiceListener.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/frankframework/http/cxf/NamespaceUriProvider.java
Show resolved
Hide resolved
tnleeuw
approved these changes
Jun 5, 2025
core/src/main/java/org/frankframework/http/WebServiceListener.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Tim van der Leeuw <tnleeuw@gmail.com>
|
evandongen
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.