Fix GraalJS JavascriptEngine arguments #9044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evandongen
approved these changes
May 26, 2025
| @@ -92,6 +92,9 @@ public Object executeFunction(String name, Object... parameters) throws Javascri | |||
| } | |||
| return result; | |||
| } catch (Exception e) { | |||
| if ("undefined:0: TypeError: undefined is not a function".equals(e.getMessage())) { | |||
There was a problem hiding this comment.
Dat eerste stukje voor TypeError lijkt dynamisch, zeker weten?
tnleeuw
approved these changes
May 26, 2025
| Object result = engine.executeFunction("test"); | ||
| assertEquals("Hello World!", result.toString()); | ||
| engine.closeRuntime(); | ||
| } | ||
|
|
||
| // This test doesn't do much at the moment... We cannot capture the log output (yet). |
There was a problem hiding this comment.
Klopt dit statement nog? Je had toch een LogHandler toegevoegd?
There was a problem hiding this comment.
Ja, maar de truffel logger is erg raar, heb hier 2uur in gestoken en was niets opgeschoten. In theorie zou alles moeten werken, er is een logger, maar ik krijg nooit log output...
nielsm5
added a commit
that referenced
this pull request
May 26, 2025
(cherry picked from commit a5ca2c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.