Add DataSonnetErrorMessageFormatter #8990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orMessageFormatter
…rrorMessageFormatter.java Co-authored-by: Erik <dongenevan@gmail.com>
…and potentially others
…/8976_AddDataSonnetErrorMessageFormatter
# Conflicts: # core/src/main/java/org/frankframework/errormessageformatters/ErrorMessageFormatter.java # core/src/main/java/org/frankframework/errormessageformatters/SoapErrorMessageFormatter.java # nn-specials/src/main/java/org/frankframework/errormessageformatters/Y01ErrorMessageFormatter.java
…/8976_AddDataSonnetErrorMessageFormatter
…/8976_AddDataSonnetErrorMessageFormatter
…atter # Conflicts: # core/src/main/java/org/frankframework/errormessageformatters/ErrorMessageFormatter.java # core/src/main/java/org/frankframework/errormessageformatters/XslErrorMessageFormatter.java
…nsistency across the code.
… the output message that was different between local runs and maven runs)
evandongen
approved these changes
May 19, 2025
| private Mapper mapper; | ||
| private DataSonnetOutputType outputType = DataSonnetOutputType.JSON; | ||
| private JsonMapper mapper; | ||
| private JsonMapper.DataSonnetOutputType outputType = JsonMapper.DataSonnetOutputType.JSON; |
There was a problem hiding this comment.
Ik vind het denk ik duidelijker om deze enum in een aparte class te zetten aangezien hij nu op meer dan 1 plek wordt gebruikt
…hod from Misc to JsonUtil.
nielsm5
reviewed
May 19, 2025
| @@ -133,7 +134,7 @@ public void testPrettyJson() throws IOException { | |||
| String inputString = StreamUtil.resourceToString(input); | |||
There was a problem hiding this comment.
Eigenlijk moeten deze tests verplaats worden naar een TestJsonUtil class 😄
nielsm5
reviewed
May 19, 2025
| @@ -273,4 +273,11 @@ public int size() { | |||
| } | |||
| return parameters.size(); | |||
| } | |||
|
|
|||
| public List<String> getParameterNames() { | |||
There was a problem hiding this comment.
Namen hoeven niet uniek te zijn, misschien handig dat hier nog even bij te zetten? Of komen ze dan tweemaal in de lijst (ook dan handig te noteren)?
…atter # Conflicts: # test/src/test/java/org/frankframework/runner/RunLarvaTests.java
|
nielsm5
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.