Larva Output Refactoring #8974
Merged
Larva Output Refactoring #8974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… LarvaMessages that can be used to return log messages in API calls that do not provide an output writer.
…which shouldn't be there anymore
evandongen
approved these changes
May 15, 2025
| @@ -52,6 +52,6 @@ public static LarvaLogLevel parse(String value, LarvaLogLevel defaultValue) { | |||
| } | |||
|
|
|||
| public boolean shouldLog(@Nullable LarvaLogLevel other) { | |||
| return other == null || this.index <= other.index; | |||
| return other == null || this.ordinal() <= other.ordinal(); | |||
nielsm5
reviewed
May 16, 2025
Comment on lines
65
to
66
| System.err.println("log.dir=" + System.getProperty("log.dir")); | ||
| System.err.println("log.dir=" + AppConstants.getInstance().getProperty("log.dir")); |
There was a problem hiding this comment.
is het handig deze twee de zelfde 'key' te geven?
There was a problem hiding this comment.
Oh, dat is wat debug-output die ik had toegevoegd omdat ik wou weten waarom iets mis ging. Was niet de bedoeling om dat te committen 🫣
|
evandongen
approved these changes
May 19, 2025
nielsm5
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Larva so it does not always need to have an outputstream available, but only when running scenarios (and core code only really depends on it for logs).
This is to enable Larva functionality to be called as library component, or from regular remote API calls.