Fix WebServiceListener result message closed too early #8969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnleeuw
approved these changes
May 15, 2025
| @@ -345,19 +351,64 @@ public void sendMessageWithImageAttachmentsWithoutContentType() throws Exception | |||
| testAttachment(message, getFile(attachmentFile).asString(), "image/bmp"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void vrijeBerichtenSoapTest() throws Exception { | |||
There was a problem hiding this comment.
I don't like the name of this test, isn't there a better name for what we're actually testing rather than the message format we're using for the test?
evandongen
approved these changes
May 15, 2025
| @@ -55,16 +55,16 @@ private void determineContentType(String newContentType) { | |||
| if(StringUtils.isNotEmpty(newContentType)) { | |||
| MimeType mimeType = MimeType.valueOf(newContentType); | |||
| if(mimeType != DEFAULT_MIMETYPE) { | |||
| this.contentType = mimeType.toString(); //use the parsed MimeType to ensure its validity | |||
| this.contentType = mimeType.toString(); // Use the parsed MimeType to ensure its validity | |||
There was a problem hiding this comment.
Ik zou hier graag consequent this.contentType of contentType zien
| @@ -345,19 +351,64 @@ public void sendMessageWithImageAttachmentsWithoutContentType() throws Exception | |||
| testAttachment(message, getFile(attachmentFile).asString(), "image/bmp"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void vrijeBerichtenSoapTest() throws Exception { | |||
| SOAPMessage request = createMessage("VrijeBerichten_PipelineRequest.xml", false, true); | |||
There was a problem hiding this comment.
Geldt hier dan ook voor lijkt me
nielsm5
commented
May 15, 2025
core/src/test/java/org/frankframework/http/cxf/SoapProviderTest.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.