Disable testtool echo2 by default #8961
Conversation
| if (attributes == null) | ||
| return false; | ||
|
|
||
| if (!attributes.containsKey("name") || !attributes.containsKey("value") || !attributes.containsKey("defaultValue")) |
There was a problem hiding this comment.
Will you always need to set defaultValue on the annotation?
There was a problem hiding this comment.
You could also argument that if no value is found it resolves to false, and if you wish to check if its empty you must provide @ConditionalOnAppConstants(name="something", value="")
There was a problem hiding this comment.
Added a default to defaultValue in the annotation and remove the need for defaultValue to be set in the attributes map
c5e88a2 to
6785efd
Compare
| if (attributes == null) | ||
| return false; | ||
|
|
||
| if (!attributes.containsKey("name") || !attributes.containsKey("value") || !attributes.containsKey("defaultValue")) |
There was a problem hiding this comment.
You could also argument that if no value is found it resolves to false, and if you wish to check if its empty you must provide @ConditionalOnAppConstants(name="something", value="")
Co-authored-by: Niels Meijer <nielsmeijer@hotmail.com>
This is not needed anymore because even if its not directly stated in the AppConstants, the context environment will have the value filled in if the property is set internally
|
No description provided.