Always Use ErrorMessageFormatter from the Adapter #8953
Conversation
| } else { | ||
| return message + ": "+t.getMessage(); | ||
| } |
There was a problem hiding this comment.
| } else { | |
| return message + ": "+t.getMessage(); | |
| } | |
| } | |
| return message + ": "+t.getMessage(); |
| PipeForward exceptionForward = findForward(PipeForward.EXCEPTION_FORWARD_NAME); | ||
| if (exceptionForward != null) { | ||
| log.warn("exception occurred, forwarded to [{}]", exceptionForward.getPath(), e); | ||
| return new PipeRunResult(exceptionForward, new ErrorMessageFormatter().format(null, e, this, message, session.getMessageId(), 0)); | ||
| } |
There was a problem hiding this comment.
Ging dit goed? erg fijn dat deze pukkel weg is.
There was a problem hiding this comment.
Ja dat lijkt goed te gaan! UnitTest hiermee uitgebreid.
| PipeRunResult prr = doPipe(pipe, DUMMY_STRING_SEMI_COLON, session); | ||
| // Verify that behaviour does not change when using the ExceptionHandlingPipeProcessor for exception forwarding instead of handling it in the CompressPipe | ||
| ExceptionHandlingPipeProcessor ehpp = new ExceptionHandlingPipeProcessor(); | ||
| CorePipeProcessor cpp = new CorePipeProcessor(); |
There was a problem hiding this comment.
Dit is de binneste processor, daar zit de exceptionhandling-pipe-processor niet omheen toch?
There was a problem hiding this comment.
Omdat CorePipeProcessor de binnentste is, wordt deze aangeroepen door de ExceptionHandlingPipeProcessor.
De ExceptionHandlingPipeProcessor moet een genestte PipeProcessor hebben, anders komt er een NullPointerException.
There was a problem hiding this comment.
Ok, nu snap ik hem. doPipe in de PipeTestBase roept inderdaad de processor niet aan (al is die er wel).
|
A small first step towards improving our ErrorMessageFormatters
Closes #8952