Allow JWT Token to omit "Bearer" when it is a non-standard header. #8818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evandongen
approved these changes
Apr 15, 2025
| @@ -96,6 +96,7 @@ public class ApiListener extends PushingListenerAdapter implements HasPhysicalDe | |||
| * These are names that are never allowed as HTTP parameters, because the Frank!Framework sets these names as session variables. | |||
| */ | |||
| public static final Set<String> RESERVED_NAMES = Set.of(PipeLineSession.ORIGINAL_MESSAGE_KEY, PipeLineSession.API_PRINCIPAL_KEY, PipeLineSession.HTTP_METHOD_KEY, PipeLineSession.HTTP_REQUEST_KEY, PipeLineSession.HTTP_RESPONSE_KEY, PipeLineSession.SECURITY_HANDLER_KEY, "ClaimsSet", "allowedMethods", "headers", ApiListenerServlet.UPDATE_ETAG_CONTEXT_KEY, "uri", "remoteAddr", ApiListenerServlet.AUTHENTICATION_COOKIE_NAME, MultipartUtils.MULTIPART_ATTACHMENTS_SESSION_KEY); | |||
| public static final String DEFAULT_AUTHORIZATION_HEADER = "Authorization"; | |||
There was a problem hiding this comment.
Hier kan je denk ik ook gebruik maken van HttpHeaders.AUTHORIZATION, daar staan ze allemaal in als het goed is
|
nielsm5
reviewed
Apr 15, 2025
| @@ -1345,11 +1346,9 @@ public void testRequestWithMessageIdAndCorrelationId() throws IOException, Confi | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @EnumSource(HttpMethod.class) | |||
| //you may not set the OPTIONS method on an ApiListener, the Servlet should handle this without calling the adapter | |||
| @EnumSource(value = HttpMethod.class, mode = EnumSource.Mode.EXCLUDE, names = { "OPTIONS" }) | |||
There was a problem hiding this comment.
Tsja, beetje omslachtig vind ik het wel, maar je hebt nu niet 1 test die "ignored" is. En helaas kon ik ook niet direct de enum-waarde zelf gebruiken.
nielsm5
approved these changes
Apr 15, 2025
tnleeuw
added a commit
that referenced
this pull request
Apr 15, 2025
) (cherry picked from commit c81e704)
tnleeuw
added a commit
that referenced
this pull request
Apr 15, 2025
) (cherry picked from commit c81e704)
tnleeuw
added a commit
that referenced
this pull request
Apr 15, 2025
) (cherry picked from commit c81e704)
tnleeuw
added a commit
that referenced
this pull request
Apr 15, 2025
) (cherry picked from commit c81e704)
tnleeuw
added a commit
that referenced
this pull request
Apr 15, 2025
) (cherry picked from commit c81e704)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8773.